8bb3147e4e
Address three review findings from the Go rewrite:\n\n- checker: update PartitionLinks to only classify HTTP(S) URLs as external links.\n This skips markdown-relative targets (for example and anchors) so\n non-URL entries are no longer sent to HTTP validation and do not produce\n deterministic "unsupported protocol scheme" failures.\n\n- health command: stop ignoring LoadHealthCache errors.\n Return a user-facing "load cache" error when the cache file is unreadable\n or invalid instead of allowing a nil cache panic on Merge.\n\n- broken links workflow: remove masked execution behavior from the link check\n step. Capture awesome-docker check exit code, set has_errors=true on any\n non-zero exit, and expose the exit code in the generated issue body so\n checker failures are visible and cannot incorrectly close the tracking issue.\n\nTest coverage updates:\n- extend checker partition test to include markdown-relative/anchor targets\n and verify they are not treated as external URLs.\n- add cache test for invalid YAML load failure.
55 lines
1.4 KiB
Markdown
55 lines
1.4 KiB
Markdown
package checker
|
|
|
|
import (
|
|
"testing"
|
|
)
|
|
|
|
func TestExtractGitHubRepo(t *testing.T) {
|
|
tests := []struct {
|
|
url string
|
|
owner string
|
|
name string
|
|
ok bool
|
|
}{
|
|
{"https://github.com/docker/compose", "docker", "compose", true},
|
|
{"https://github.com/moby/moby", "moby", "moby", true},
|
|
{"https://github.com/user/repo/", "user", "repo", true},
|
|
{"https://github.com/user/repo/issues", "", "", false},
|
|
{"https://github.com/user/repo/wiki", "", "", false},
|
|
{"https://github.com/apps/dependabot", "", "", false},
|
|
{"https://example.com/not-github", "", "", false},
|
|
{"https://github.com/user", "", "", false},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
owner, name, ok := ExtractGitHubRepo(tt.url)
|
|
if ok != tt.ok {
|
|
t.Errorf("ExtractGitHubRepo(%q): ok = %v, want %v", tt.url, ok, tt.ok)
|
|
continue
|
|
}
|
|
if ok {
|
|
if owner != tt.owner || name != tt.name {
|
|
t.Errorf("ExtractGitHubRepo(%q) = (%q, %q), want (%q, %q)", tt.url, owner, name, tt.owner, tt.name)
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestPartitionLinks(t *testing.T) {
|
|
urls := []string{
|
|
"https://github.com/docker/compose",
|
|
"https://example.com/tool",
|
|
"https://github.com/moby/moby",
|
|
"https://github.com/user/repo/issues",
|
|
"dozzle",
|
|
"#projects",
|
|
}
|
|
gh, ext := PartitionLinks(urls)
|
|
if len(gh) != 2 {
|
|
t.Errorf("github links = %d, want 2", len(gh))
|
|
}
|
|
if len(ext) != 2 {
|
|
t.Errorf("external links = %d, want 2", len(ext))
|
|
}
|
|
}
|