From a1fa7011cd569b803ac28c98abc170aac6885bfd Mon Sep 17 00:00:00 2001
From: Gal Elmalah <gale@wix.com>
Date: Sun, 11 Oct 2020 11:59:15 +0300
Subject: [PATCH] fix sorting by year and rating bug

---
 app/src/components/feed.js           | 2 ++
 app/src/components/sortByDropdown.js | 4 ++--
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/app/src/components/feed.js b/app/src/components/feed.js
index c4d5c59..9a00dc6 100644
--- a/app/src/components/feed.js
+++ b/app/src/components/feed.js
@@ -10,6 +10,8 @@ export default ({ data, limit }) => {
     .slice(0, limit || data.allBooksJson.edges.length)
     .sort(compareFunctions[sortBy]);
 
+  console.log(getSortedBooks());
+
   const handleSortByItemClick = (field) => {
     setSortBy(field);
   };
diff --git a/app/src/components/sortByDropdown.js b/app/src/components/sortByDropdown.js
index e4b6f3e..fb07d59 100644
--- a/app/src/components/sortByDropdown.js
+++ b/app/src/components/sortByDropdown.js
@@ -3,8 +3,8 @@ import { Dropdown } from 'react-bootstrap';
 
 export const compareFunctions = {
   title: ({ node: bookOne }, { node: bookTwo }) => bookOne.title.localeCompare(bookTwo.title),
-  year: ({ node: bookOne }, { node: bookTwo }) => bookTwo.year - bookOne.year,
-  rating: ({ node: bookOne }, { node: bookTwo }) => bookTwo.rating - bookOne.rating,
+  year: ({ node: bookOne }, { node: bookTwo }) => Number(bookTwo.year) - Number(bookOne.year),
+  rating: ({ node: bookOne }, { node: bookTwo }) => Number(bookTwo.rating) - Number(bookOne.rating),
 };
 
 export const FIELDS_TO_SORT_BY = ['rating', 'year', 'title'];